fix(friends): Display issue for users with unfetchable test amount; Fixes #8189 (@brentspine)#8190
Open
brentspine wants to merge 2 commits into
Open
fix(friends): Display issue for users with unfetchable test amount; Fixes #8189 (@brentspine)#8190brentspine wants to merge 2 commits into
brentspine wants to merge 2 commits into
Conversation
github-actions
Bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Fix friends list “tests” column rendering when a user’s completedTests/startedTests stats are missing, avoiding undefined/x UI.
Changes:
- Render
-for thetestscell when either count isundefined. - Skip tooltip metadata when counts are missing (prevents broken
aria-label).
Miodec
requested changes
Jul 3, 2026
Comment on lines
+729
to
+735
| restartRatio: | ||
| stats.completedTests === 0 | ||
| ? "-" | ||
| : ( | ||
| (stats.startedTests - stats.completedTests) / | ||
| stats.completedTests | ||
| ).toFixed(1), |
Member
There was a problem hiding this comment.
Extract to a const to make it more readable
Comment on lines
+186
to
+188
| return completedTests === undefined || startedTests === undefined | ||
| ? "-" | ||
| : `${completedTests}/${startedTests}`; |
Member
There was a problem hiding this comment.
Change to this?
return `${completedTests ?? 0}/${startedTests ?? 0}`;
github-actions
Bot
added
waiting for update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes display issue:
Checks
Closes #8189